refactor_loggers #1

Merged
medvedych merged 3 commits from refactor_loggers into master 2023-03-17 22:37:07 +03:00
2 changed files with 12 additions and 12 deletions
Showing only changes of commit 56215cf0d3 - Show all commits

View file

@ -13,7 +13,7 @@ my $LEVELS = {
warn => 2, warn => 2,
info => 3, info => 3,
debug => 4, debug => 4,
trace => 5 trace => 5,
}; };
sub new sub new
@ -39,7 +39,7 @@ sub set_level
$self->{'level'} = $new_level; $self->{'level'} = $new_level;
return; return 1;
} }
sub level sub level
@ -71,7 +71,7 @@ sub _log
$self->_print($text); $self->_print($text);
return; return 1;
} }
sub _print { croak 'Not implemented!' } sub _print { croak 'Not implemented!' }

View file

@ -14,9 +14,9 @@ subtest 'creates correct object' => sub {
subtest 'prints to file' => sub { subtest 'prints to file' => sub {
for my $level (qw/error warn debug/) { for my $level (qw/error warn info debug trace/) {
my $file = File::Temp->new; my $file = File::Temp->new;
my $log = _build_logger(file => $file->filename); my $log = _build_logger(file => $file->filename, level => $level);
$log->$level('message'); $log->$level('message');
undef $log; undef $log;
@ -31,7 +31,8 @@ subtest 'prints to file synced' => sub {
my $file = File::Temp->new; my $file = File::Temp->new;
my $log = _build_logger(file => $file->filename, synced => 1); my $log = _build_logger(file => $file->filename, synced => 1);
for my $level (qw/error warn debug/) { for my $level (qw/error warn info debug trace /) {
$log->set_level($level);
$log->$level('message'); $log->$level('message');
my $content = _slurp($file); my $content = _slurp($file);
@ -41,10 +42,9 @@ subtest 'prints to file synced' => sub {
}; };
subtest 'prints to stderr with \n' => sub { subtest 'prints to stderr with \n' => sub {
for my $level (qw/error warn debug/) { for my $level (qw/error warn info debug trace/) {
my $file = File::Temp->new; my $file = File::Temp->new;
my $log = _build_logger(file => $file->filename); my $log = _build_logger(file => $file->filename, level => $level);
$log->$level('message'); $log->$level('message');
@ -57,9 +57,9 @@ subtest 'prints to stderr with \n' => sub {
}; };
subtest 'prints sprintf formatted line' => sub { subtest 'prints sprintf formatted line' => sub {
for my $level (qw/error warn debug/) { for my $level (qw/error warn info debug trace/) {
my $file = File::Temp->new; my $file = File::Temp->new;
my $log = _build_logger(file => $file->filename); my $log = _build_logger(file => $file->filename, level => $level);
$log->$level('message %s', 'formatted'); $log->$level('message %s', 'formatted');
@ -80,7 +80,7 @@ sub _slurp {
sub _build_logger { sub _build_logger {
my $logger = Log::Mini::Logger::FILE->new(@_); my $logger = Log::Mini::Logger::FILE->new(@_);
$logger->set_level('debug');
return $logger; return $logger;
} }