medvedych/harbour-books
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

[app] Eliminated unnecessary QML object creation

Browse source
This commit is contained in:
Slava Monich 2018-01-20 13:49:51 +02:00
parent feffa61273
commit 3325aad1b2
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/qml/BooksStorageView.qml
View file

@ -1,5 +1,5 @@
/* /*
Copyright (C) 2015-2016 Jolla Ltd. Copyright (C) 2015-2018 Jolla Ltd.
Contact: Slava Monich <slava.monich@jolla.com> Contact: Slava Monich <slava.monich@jolla.com>
You may use this file under the terms of BSD license as follows: You may use this file under the terms of BSD license as follows:
@ -99,9 +99,7 @@ SilicaFlickable {
onClicked: { onClicked: {
if (!_settingsComponent) { if (!_settingsComponent) {
_settingsComponent = Qt.createComponent("../settings/BooksSettings.qml") _settingsComponent = Qt.createComponent("../settings/BooksSettings.qml")
if (_settingsComponent.status === Component.Ready) { if (_settingsComponent.status !== Component.Ready) {
_settingsComponent.createObject(storageView)
} else {
console.log(_settingsComponent.errorString()) console.log(_settingsComponent.errorString())
} }
} }