From 8a247fb7e21949bb13512077f40e295794eb8590 Mon Sep 17 00:00:00 2001 From: Slava Monich Date: Sat, 10 Oct 2020 19:02:42 +0300 Subject: [PATCH] [settings] Fixed initial selection of orientation combo box --- app/settings/BooksSettings.qml | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/app/settings/BooksSettings.qml b/app/settings/BooksSettings.qml index f3dca3a..6ae4ec0 100644 --- a/app/settings/BooksSettings.qml +++ b/app/settings/BooksSettings.qml @@ -1,6 +1,6 @@ /* - Copyright (C) 2015-2018 Jolla Ltd. - Copyright (C) 2015-2018 Slava Monich + Copyright (C) 2015-2020 Jolla Ltd. + Copyright (C) 2015-2020 Slava Monich You may use this file under the terms of BSD license as follows: @@ -8,14 +8,15 @@ modification, are permitted provided that the following conditions are met: - * Redistributions of source code must retain the above copyright - notice, this list of conditions and the following disclaimer. - * Redistributions in binary form must reproduce the above copyright - notice, this list of conditions and the following disclaimer in the - documentation and/or other materials provided with the distribution. - * Neither the name of Jolla Ltd nor the names of its contributors may - be used to endorse or promote products derived from this software - without specific prior written permission. + 1. Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + 2. Redistributions in binary form must reproduce the above copyright + notice, this list of conditions and the following disclaimer + in the documentation and/or other materials provided with the + distribution. + 3. Neither the names of the copyright holders nor the names of its + contributors may be used to endorse or promote products derived + from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE @@ -121,22 +122,25 @@ Page { id: orientationMenu readonly property int defaultIndex: 0 MenuItem { + readonly property int value: 0 //: Combo box value for dynamic orientation //% "Dynamic" text: qsTrId("harbour-books-settings-page-orientation-dynamic") - onClicked: orientation.value = 0 + onClicked: orientation.value = value } MenuItem { + readonly property int value: 1 //: Combo box value for portrait orientation //% "Portrait" text: qsTrId("harbour-books-settings-page-orientation-portrait") - onClicked: orientation.value = 1 + onClicked: orientation.value = value } MenuItem { + readonly property int value: 2 //: Combo box value for landscape orientation //% "Landscape" text: qsTrId("harbour-books-settings-page-orientation-landscape") - onClicked: orientation.value = 2 + onClicked: orientation.value = value } } Component.onCompleted: orientation.updateControls()