Commit graph

155 commits

Author SHA1 Message Date
John Gibbon
fdb8cc5852 replace variant with var
https://doc.qt.io/archives/qt-5.6/qtquick-performance.html
In general, "property var" should be considered to be superior to "property variant" for every use-case from QtQuick 2.0 and newer (note that "property variant" is marked as obsolete), as it allows a true JavaScript reference to be stored (which can reduce the number of conversions required in certain expressions).
2020-11-05 23:23:37 +01:00
John Gibbon
37bede461b differentiate between simple/normal messages 2020-11-05 14:05:33 +01:00
Sebastian Wolf
179ef885b5 Chat Information Page: More tweaks 2020-11-02 23:19:50 +01:00
Sebastian Wolf
5ee71dda29 Chat Information Page: Improvements for channels 2020-11-02 22:51:12 +01:00
John Gibbon
5903fbc4da Set initial scroll position for ChatPage
Fixes #1
2020-11-02 20:54:18 +01:00
Sebastian Wolf
cccb48ced5
Merge pull request #119 from jgibbon/feature/qml-import-versions
clean up qml imports
2020-11-01 19:37:49 +01:00
John Gibbon
3f454711cf remove some unused imports 2020-10-31 21:09:59 +01:00
John Gibbon
f4d0a4800e QtMultimedia 5.6 2020-10-31 20:50:32 +01:00
John Gibbon
2cd4012b6a QtQuick 2.6 2020-10-31 20:49:03 +01:00
John Gibbon
1fa7192728 Reduce ChatPage.qml jit compile time
First of all: Take all measurements I mention with a grain of salt – all of them are rough and not necessarily measured more than a few times. All times were measured on an Xperia X run via SDK.

Visiting a chat page can take a long time, especially before the qml is cached by the engine.
When opening it for the first time after application launch, it sometimes takes >1000ms from onClicked (OverviewPage) to Component.OnCompleted (Chatpage).
Subsequent activations take roughly 470-480ms.

With these changes, I was able to reduce these times to ~450ms for the first, ~100ms for subsequent activations of the ChatPage on my test device.

Things changed:
- The components for displaying extra content to a message are (mostly) gone and replaced by a single Loader. This Loader does not use sourceComponent to trade the initial compilation boost for a neglegible bit of runtime penalty.
- Connections were consolidated
- I was surprised how costly the inclusion of the RemorseItem was (compiling ~75ms, initializing up to ~20ms for every delegate). So I traded a bit for a compromise. deleteMessageRemorseItem is now defined on the appWindow level, where it gets a bit mitigated by the animations at application start. Also, only one deletion at a time is now possible. We can easily revert this change, but I thought it worthwhile despite its drawbacks.
- profileThumbnailComponent is now defined directly as sourceComponent, removing the need for its id. Probably didn't do anything.
- InReplyToRow had width: parent.width, so I removed horizontalCenter. Also probably didn't change compilation time at all.
- Another compromise I was willing to take – your opinion may differ: The PickerPages took ages (~200ms) to just parse/compile inside those Components, so I replaced them with the "string notation" of pageStack.push. Drawback: The first time a picker gets activated, you'll see how slow it is. Subsequent activations aren't that bad – also for the other pickers.
2020-10-30 20:37:25 +01:00
Sebastian Wolf
d45eb28daa Minor changes to poll display & translation adjustments 2020-10-29 22:39:43 +01:00
John Gibbon
894e9af0c0 Fix two issues in PollPreview
- The new emoji basePath workaround also works for TextSwitch content.
 - Checking which context menu entries get added for the poll preview didn't quite work nicely "OnCompleted".
2020-10-28 08:11:14 +01:00
John Gibbon
8c69e04e83 Fix emoji paths for chat information Items 2020-10-27 21:42:39 +01:00
Sebastian Wolf
3402fddaa6
Merge branch 'master' into feature/use-svgs 2020-10-26 22:17:13 +01:00
John Gibbon
d38490fb09 use svg icons
Closes #102.

Doesn't use Shader/HighlightImage for background/placeholder, since that neither matched the previous look nor meet my visual expectations at all. I created both previously available color variations as svg accordingly.
Implementation of the background images has been outsourced to a dedicated qml file to reduce duplication and ensure the same layout. Padding is now "medium" everywhere (stickers had none, audio had "small").

For the Icons, some (Highlight-)Image+MouseArea combinations have been changed to IconButton.
Regarding videos, I'm not actually sure if the missing "highlight" on the fullscreen icon was intentional. An issue with videos possibly having the same color as the icon remains basically the same. Nonetheless, if this isn't desired, I'll revert to just using the white image.

The sticker icon actually does look a bit differently now – it's a bit smaller. I've redrawn it from scratch but mostly kept the dimensions of icon-m-other (which doesn't look good when zoomed in, btw). Perhaps I actually did made a mistake drawing the previous one. Either way, I think it fits well enough.

The notification icon remains png, but I managed to reduce its file size by ~60% without visibly impacting it much imho.

This may be the longest commit message I've ever written.
2020-10-26 15:15:53 +01:00
John Gibbon
c4d67de8a5 streamline behaviours/animations 2020-10-24 19:32:21 +02:00
John Gibbon
924ff9deda implement polls 2020-10-23 10:29:56 +02:00
John Gibbon
6970dc3625 implement "mark all messages as read" MenuItem
contributes to #70 (doesn't mark anything as unread, though, and does not use toggleChatIsMarkedAsUnread at all)
2020-10-19 21:08:32 +02:00
John Gibbon
214a6c780c Fix crash with no groups in common 2020-10-19 21:06:28 +02:00
Sebastian J. Wolf
91ae3651ef Change license header to reflect number of contributions 2020-10-19 19:34:47 +02:00
John Gibbon
74a732a5b6 implement chat info page
includes some basic group administration features
2020-10-19 12:48:55 +02:00
Sebastian J. Wolf
dba973b522 Introduce explicit clear button for in-reply-to and edit message, fixes #69 2020-10-18 21:54:15 +02:00
Slava Monich
f86e60b4a2 Let context menu to appear when sticker is long-pressed
And don't load placeholder image too quickly.
2020-10-18 21:10:26 +03:00
Sebastian J. Wolf
e578c6bef3 Use GridView for sticker picker 2020-10-18 16:29:34 +02:00
Sebastian J. Wolf
f9221fe95e Now the sticker picker looks much better... 2020-10-15 23:43:55 +02:00
Sebastian J. Wolf
537725566b Supporting stickers is quite some work... :/ 2020-10-14 23:25:56 +02:00
Sebastian J. Wolf
bfba8acc2d Web page preview changes height a little more dynamically 2020-10-13 21:37:06 +02:00
Sebastian J. Wolf
67669cf63f Make some space for lazy-loaded elements, part 1 2020-10-11 22:02:30 +02:00
Sebastian J. Wolf
c0269b5502 Display information for forwarded messages 2020-10-07 22:17:44 +02:00
Sebastian J. Wolf
bfe3084d2e Differentiate text between other people and user 2020-09-30 00:09:51 +02:00
Sebastian J. Wolf
97e72bac9b Introduce upload status bar 2020-09-29 23:37:56 +02:00
John Gibbon
75ef6e70a4 update live locations 2020-09-29 15:50:21 +02:00
John Gibbon
b58e33b2a4 Handle display of messageLocation
resolves #36
2020-09-28 22:59:47 +02:00
Sebastian J. Wolf
0e1169e7f4 Some delay for lazy loading... 2020-09-22 22:46:48 +02:00
Sebastian J. Wolf
fcc46fbc94 Auto-scroll to message if user sent it 2020-09-22 20:32:35 +02:00
Sebastian J. Wolf
ea123b08ea Put an action behind new message count circle, fixes #13 2020-09-22 19:26:49 +02:00
Sebastian J. Wolf
c5dade71b0 Introduce some lazy loading 2020-09-21 22:10:03 +02:00
Sebastian J. Wolf
ed170dc374 Don't display zeros in webpage previews 2020-08-30 15:59:34 +02:00
Sebastian J. Wolf
a527009f86 Don't do stuff which is not needed ;) 2020-08-29 16:58:48 +02:00
Sebastian J. Wolf
391dd597e2 Initial performance improvements 2020-08-29 16:32:43 +02:00
Sebastian J. Wolf
6c269780b2 Add web page preview 2020-08-29 15:51:48 +02:00
Sebastian J. Wolf
a24bf81355 Some work on reply management, still some work to do... 2020-08-29 11:22:18 +02:00
Sebastian J. Wolf
402c0ed671 Add possibility to send replies 2020-08-28 17:40:25 +02:00
Sebastian J. Wolf
ecf4c859e8 Add support for documents 2020-08-28 16:18:33 +02:00
Sebastian J. Wolf
0b77f1527d Add support for voice notes 2020-08-28 14:14:05 +02:00
Sebastian J. Wolf
b55be4289c Add support for animated GIFs 2020-08-28 13:02:54 +02:00
Sebastian J. Wolf
50a67bb037 Add fullscreen video page 2020-08-28 11:43:51 +02:00
Sebastian J. Wolf
c741a157b7 Introduce video preview 2020-08-28 10:41:18 +02:00
Sebastian J. Wolf
abdf9072e7 Display stickers (use thumbnails for animated ones) 2020-08-26 10:46:43 +02:00
Sebastian J. Wolf
b899d03660 Display images in messages and introduce image page 2020-08-24 23:02:08 +02:00
Sebastian J. Wolf
543ba5d46b Force list item update after changed chats 2020-08-21 09:29:19 +02:00
Sebastian J. Wolf
ddd894bdfa Display chat pictures properly 2020-08-19 16:47:59 +02:00
Sebastian J. Wolf
c44d85732c First steps to get a chat list on screen :) 2020-08-19 09:55:13 +02:00
Sebastian J. Wolf
39587a7724 Add nice rounded corners for thumbnail 2020-08-14 11:11:34 +02:00
Sebastian J. Wolf
41ac3c4829 Bring own profile picture to the about page 2020-08-14 10:33:42 +02:00