Commit graph

371 commits

Author SHA1 Message Date
iamnomeutente
ba0038ef8c Merge remote-tracking branch 'upstream/master' 2020-10-31 09:38:51 +01:00
John Gibbon
1fa7192728 Reduce ChatPage.qml jit compile time
First of all: Take all measurements I mention with a grain of salt – all of them are rough and not necessarily measured more than a few times. All times were measured on an Xperia X run via SDK.

Visiting a chat page can take a long time, especially before the qml is cached by the engine.
When opening it for the first time after application launch, it sometimes takes >1000ms from onClicked (OverviewPage) to Component.OnCompleted (Chatpage).
Subsequent activations take roughly 470-480ms.

With these changes, I was able to reduce these times to ~450ms for the first, ~100ms for subsequent activations of the ChatPage on my test device.

Things changed:
- The components for displaying extra content to a message are (mostly) gone and replaced by a single Loader. This Loader does not use sourceComponent to trade the initial compilation boost for a neglegible bit of runtime penalty.
- Connections were consolidated
- I was surprised how costly the inclusion of the RemorseItem was (compiling ~75ms, initializing up to ~20ms for every delegate). So I traded a bit for a compromise. deleteMessageRemorseItem is now defined on the appWindow level, where it gets a bit mitigated by the animations at application start. Also, only one deletion at a time is now possible. We can easily revert this change, but I thought it worthwhile despite its drawbacks.
- profileThumbnailComponent is now defined directly as sourceComponent, removing the need for its id. Probably didn't do anything.
- InReplyToRow had width: parent.width, so I removed horizontalCenter. Also probably didn't change compilation time at all.
- Another compromise I was willing to take – your opinion may differ: The PickerPages took ages (~200ms) to just parse/compile inside those Components, so I replaced them with the "string notation" of pageStack.push. Drawback: The first time a picker gets activated, you'll see how slow it is. Subsequent activations aren't that bad – also for the other pickers.
2020-10-30 20:37:25 +01:00
Sebastian Wolf
72315312d6
Merge pull request #113 from jgibbon/feature/reenable-poll-type-display
add poll preview type output
2020-10-30 20:28:43 +01:00
Sebastian Wolf
46ffdc68c4
Merge pull request #112 from GNUuser/patch-12
Update harbour-fernschreiber-es.ts
2020-10-30 20:25:55 +01:00
John Gibbon
c185ba1b42 add poll preview type output
as discussed in d45eb28daa
2020-10-30 19:07:06 +01:00
carlosgonz
47d5ec73a3
Update harbour-fernschreiber-es.ts 2020-10-29 18:51:38 -04:00
Sebastian Wolf
d45eb28daa Minor changes to poll display & translation adjustments 2020-10-29 22:39:43 +01:00
Sebastian Wolf
e3224c5b4f
Merge pull request #111 from jgibbon/bugfix/poll-fixes
Fix two issues in PollPreview
2020-10-29 21:57:16 +01:00
Åke Engelbrektson
0346b749fa Update harbour-fernschreiber-sv.ts
Update Swedish translation
2020-10-28 08:17:42 +01:00
John Gibbon
894e9af0c0 Fix two issues in PollPreview
- The new emoji basePath workaround also works for TextSwitch content.
 - Checking which context menu entries get added for the poll preview didn't quite work nicely "OnCompleted".
2020-10-28 08:11:14 +01:00
Sebastian Wolf
afb53965b4
Merge pull request #108 from jgibbon/bugfix/remove-path-replacement
Fix emoji paths for chat information Items
2020-10-27 22:33:13 +01:00
iamnomeutente
a50e4a48b8 Update harbour-fernschreiber-it.ts and README.md 2020-10-27 21:55:04 +01:00
John Gibbon
8c69e04e83 Fix emoji paths for chat information Items 2020-10-27 21:42:39 +01:00
iamnomeutente
aeed051afd Update harbour-fernschreiber-it.ts and README.md 2020-10-27 15:57:56 +01:00
Sebastian Wolf
7b22c522f1 Update translation files after merging several PRs 2020-10-26 22:40:53 +01:00
Sebastian Wolf
06c6943ea5
Merge pull request #106 from jgibbon/feature/use-svgs
use svg icons
2020-10-26 22:28:26 +01:00
Sebastian Wolf
3402fddaa6
Merge branch 'master' into feature/use-svgs 2020-10-26 22:17:13 +01:00
Sebastian Wolf
2a4325f4ed
Merge pull request #105 from monich/image-page
Tweaked ImagePage behavior
2020-10-26 21:55:32 +01:00
Sebastian Wolf
f2f089d5b2
Merge pull request #103 from monich/const-refs
TDLibWrapper cleanup
2020-10-26 21:36:01 +01:00
Sebastian Wolf
3175e641dc
Merge branch 'master' into const-refs 2020-10-26 21:28:39 +01:00
Sebastian Wolf
e8d33cd920
Merge pull request #101 from jgibbon/feature/display-polls
implement polls
2020-10-26 21:06:28 +01:00
John Gibbon
d38490fb09 use svg icons
Closes #102.

Doesn't use Shader/HighlightImage for background/placeholder, since that neither matched the previous look nor meet my visual expectations at all. I created both previously available color variations as svg accordingly.
Implementation of the background images has been outsourced to a dedicated qml file to reduce duplication and ensure the same layout. Padding is now "medium" everywhere (stickers had none, audio had "small").

For the Icons, some (Highlight-)Image+MouseArea combinations have been changed to IconButton.
Regarding videos, I'm not actually sure if the missing "highlight" on the fullscreen icon was intentional. An issue with videos possibly having the same color as the icon remains basically the same. Nonetheless, if this isn't desired, I'll revert to just using the white image.

The sticker icon actually does look a bit differently now – it's a bit smaller. I've redrawn it from scratch but mostly kept the dimensions of icon-m-other (which doesn't look good when zoomed in, btw). Perhaps I actually did made a mistake drawing the previous one. Either way, I think it fits well enough.

The notification icon remains png, but I managed to reduce its file size by ~60% without visibly impacting it much imho.

This may be the longest commit message I've ever written.
2020-10-26 15:15:53 +01:00
John Gibbon
c7843919a7 hide poll IconButton if not applicable 2020-10-26 10:24:50 +01:00
Sebastian Wolf
70170c894f
Merge pull request #104 from jorm1s/patch-2
Update harbour-fernschreiber-fi.ts
2020-10-25 19:17:37 +01:00
Sebastian Wolf
121ab8cff0 Fix syntax error in Italian translation 2020-10-25 19:15:55 +01:00
Sebastian Wolf
0877332251
Merge pull request #98 from GNUuser/patch-10
Update harbour-fernschreiber-es.ts
2020-10-25 19:12:58 +01:00
Slava Monich
79e06bd4c4 Tweaked ImagePage behavior
This should made reaction to a single tap more reliable and
flicking back easier.
2020-10-25 03:14:07 +03:00
John Gibbon
c4d67de8a5 streamline behaviours/animations 2020-10-24 19:32:21 +02:00
John Gibbon
d3324bfab2 slot/primitive considerations from #103 2020-10-24 19:28:20 +02:00
Miikka Jormanainen
9589d592fa Update harbour-fernschreiber-fi.ts 2020-10-24 14:52:53 +03:00
Slava Monich
080244ecb1 Removed useless slots from TDLibWrapper
Signals can be connected directly to signals.
2020-10-24 03:24:56 +03:00
Slava Monich
460eaa878f Don't pass primitive data as a const reference
It just doesn't make any sense.

Reference (essentially a pointer) can't be smaller than a primitive
type, except for 64-bit numbers on a 32-bit platform. In terms of
performance, an additional indirection can't be better than picking
the value directly from the stack, let alone a register.
2020-10-24 03:13:08 +03:00
John Gibbon
924ff9deda implement polls 2020-10-23 10:29:56 +02:00
carlosgonz
3df8c3e477
Update harbour-fernschreiber-es.ts 2020-10-22 17:51:50 -04:00
jgibbon
5d14d9b000
Merge pull request #99 from GNUuser/patch-11
Update README.md
2020-10-22 11:21:44 +02:00
carlosgonz
f153472fb6
Update README.md 2020-10-21 17:40:20 -04:00
carlosgonz
e55441df77
Update harbour-fernschreiber-es.ts 2020-10-21 17:36:28 -04:00
jgibbon
f202febc3d
Merge pull request #97 from iamnomeutente/master
Update harbour-fernschreiber-it.ts and typo in de_DE corrected
2020-10-21 16:01:49 +02:00
Matteo
d03a35afdd
Typo 2020-10-21 15:44:05 +02:00
Matteo
361add6612
Update harbour-fernschreiber-it.ts 2020-10-21 15:40:17 +02:00
Matteo
375f269a51
Syncing my fork to the original repository 2020-10-21 15:06:41 +02:00
jgibbon
748e7aa230
Merge pull request #96 from eson57/patch-1
Create harbour-fernschreiber-sv.ts
2020-10-21 09:27:24 +02:00
Åke Engelbrektson
adccbf5346
Update harbour-fernschreiber.pro
Add Swedish translation file
2020-10-21 09:23:07 +02:00
Åke Engelbrektson
706e96f2de
Create harbour-fernschreiber-sv.ts
Add Swedish translation
2020-10-21 09:21:48 +02:00
Sebastian J. Wolf
402b0ecd6e Integrate new sticker icon by @jgibbon from #86 2020-10-20 22:19:54 +02:00
Sebastian Wolf
020b076584
Merge pull request #94 from jgibbon/feature/mark-as-read
implement "mark all messages as read" MenuItem
2020-10-20 22:12:48 +02:00
John Gibbon
6970dc3625 implement "mark all messages as read" MenuItem
contributes to #70 (doesn't mark anything as unread, though, and does not use toggleChatIsMarkedAsUnread at all)
2020-10-19 21:08:32 +02:00
John Gibbon
214a6c780c Fix crash with no groups in common 2020-10-19 21:06:28 +02:00
Sebastian J. Wolf
98e2bea69f Prepare translation files for #87 2020-10-19 19:51:33 +02:00
Sebastian J. Wolf
91ae3651ef Change license header to reflect number of contributions 2020-10-19 19:34:47 +02:00